[PATCH] PR c++/33255 - Support -Wunused-local-typedefs warning

[Dodji Seketeli]

Jason Merrill <jason@redhat.com> writes:

> On 09/08/2011 04:50 PM, Dodji Seketeli wrote:
>> Is this be OK for trunk when PR preprocessor/7263 gets in, assuming it
>> passes bootstrap and tests on trunk at that moment?
>
> Yes, except...
>
>> --- a/gcc/doc/invoke.texi
>> +++ b/gcc/doc/invoke.texi
>> @@ -3505,6 +3505,7 @@ To suppress this warning use the @samp{unused} attribute
>>   @item -Wunused-local-typedefs @r{(C, Objective-C, C++ and Objective-C++ only)}
>>   @opindex Wunused-local-typedefs
>>   Warn when a typedef locally defined in a function is not used.
>> +This warning is enabled by @option{-Wall}.
>
> Don't you want to say "This warning is also enabled by
> @option{-Wunused}, which is enabled by @option{-Wall}."?

For the sake of consistency, I followed the pattern used for the other
-Wunused-* options in that same file.

I thought I didn't have to mention that -Wunused triggers
-Wunused-local-typedefs because a bit below this, the text for -Wunused
reads:

    All the above @option{-Wunused} options combined.

And before that, each relevant -Wunused-* option is said to be triggered
by -Wall, as I did.

I would also find your phrasing more logical, if it wasn't for the
consistency constraint.

-- 
		Dodji