[PATCH] strlenopt improvements

Jakub Jelinek jakub@redhat.com
Mon Oct 24 21:20:00 GMT 2011


On Mon, Oct 24, 2011 at 10:04:45PM +0200, Andreas Krebbel wrote:
> > Can you please explain this stmt_set_p stuff?  dont_invalidate should be
> > only set on strinfos that will be seen by the immediately following
> > maybe_invalidate call (at the end of handle_builtin_strcpy caller -
> > strlen_optimize_stmt).  If you set it on which unshare_strinfo is called,
> > if there is no unsharing, it is obviously fine, but if there is unsharing,
> > then dont_invalidate will be set on some strinfo that won't be seen by the
> > next may_invalidate.  It might trigger in some other basic block and might
> > cause wrong code.
> 
> It's not needed.  I've retested it with the following loop instead. No
> regressions on s390x and x86_64.  Ok to apply?

Yes, thanks.

	Jakub



More information about the Gcc-patches mailing list