[pph] Refactor Vectors and Chains (issue5263051)

[Diego Novillo]

On Sun, Oct 16, 2011 at 22:09, Lawrence Crowl <crowl@google.com> wrote:
> Factor the vector and chain output routines to remove boolean control
> parameters. The functions pph_out_tree_vec_1 and pph_out_chain_1 split
> their conditional parts of their implementation into their use cases,
> calling each other as needed.
>
> pph_out_tree_vec - nothing special
> pph_out_tree_vec_unchain - unchaining
> pph_out_mergeable_tree_vec - merging, unchaining, reversing
> pph_out_tree_vec_filtered - filtering
> pph_out_chain - nothing special
> pph_out_chain_filtered - filtering
> pph_out_mergeable_chain_filtered - merging, unchaining, reversing, filtering

But, you are duplicating code that the previous patch had explicitly
commonized.  Why?  It's easier to keep the core streaming logic in one
function, to have a single point of debugging when dealing with sync
problems.


> This change fixes an ordering bug, but now causes an ICE to surface,
> which will be addressed later.

What ordering bug?


Diego.