[PATCH 3/7] Emit macro expansion related diagnostics

Dodji Seketeli dodji@redhat.com
Mon Oct 17 09:57:00 GMT 2011


Jason Merrill <jason@redhat.com> writes:

> On 10/13/2011 01:12 PM, Dodji Seketeli wrote:
>> +  while (true)
>> +    {
>> +      if (!linemap_macro_expansion_map_p (map0)
>> +         || !linemap_macro_expansion_map_p (map1)
>> +         || map0 == map1)
>> +       break;
>
> I'd put the test in the condition, but if you find it clearer this
> way, I guess that's fine.

I've done the change.

Let's go ahead and check all this in.

Thanks.

I'll send the final set of patches I'll commit, to ease future
references.  It will not contain the patch which subject was "Kill
pedantic warnings on system headers macros" as I'll need to change the C
(and probably the C++) FE to make each declspec have its own location
first.

-- 
		Dodji



More information about the Gcc-patches mailing list