Vector shuffling

Georg-Johann Lay avr@gjlay.de
Thu Oct 6 11:38:00 GMT 2011


Richard Guenther schrieb:
> On Thu, Oct 6, 2011 at 12:51 PM, Georg-Johann Lay <avr@gjlay.de> wrote:
>> Artem Shinkarov schrieb:
>>> Hi, Richard
>>>
>>> There is a problem with the testcases of the patch you have committed
>>> for me. The code in every test-case is doubled. Could you please,
>>> apply the following patch, otherwise it would fail all the tests from
>>> the vector-shuffle-patch would fail.
>>>
>>> Also, if it is possible, could you change my name from in the
>>> ChangeLog from "Artem Shinkarov" to "Artjoms Sinkarovs". The last
>>> version is the way I am spelled in the passport, and the name I use in
>>> the ChangeLog.
>>>
>>> Thanks,
>>> Artem.
>>>
>>> On Mon, Oct 3, 2011 at 4:13 PM, Richard Henderson <rth@redhat.com> wrote:
>>>> On 10/03/2011 05:14 AM, Artem Shinkarov wrote:
>>>>> Hi, can anyone commit it please?
>>>>>
>>>>> Richard?
>>>>> Or may be Richard?
>>>> Committed.
>>>>
>>>> r~
>>>>
>>> Hi, Richard
>>>
>>> There is a problem with the testcases of the patch you have committed
>>> for me. The code in every test-case is doubled. Could you please,
>>> apply the following patch, otherwise it would fail all the tests from
>>> the vector-shuffle-patch would fail.
>>>
>>> Also, if it is possible, could you change my name from in the
>>> ChangeLog from "Artem Shinkarov" to "Artjoms Sinkarovs". The last
>>> version is the way I am spelled in the passport, and the name I use in
>>> the ChangeLog.
>>>
>>>
>>> Thanks,
>>> Artem.
>>>
>> The following test cases cause FAILs because main cannot be found by the linker
>>  because if __SIZEOF_INT__ != 4 you are trying to compile and run an empty file.
>>
>>> Index: gcc/testsuite/gcc.c-torture/execute/vect-shuffle-1.c
>>> Index: gcc/testsuite/gcc.c-torture/execute/vect-shuffle-5.c
>> The following patch avoids __SIZEOF_INT__.
>>
>> Ok by some maintainer to commit?
> 
> On a general note, if you need to add .x files, consider moving the
> test to gcc.dg/torture instead.

So should I move all vect-shuffle-*.c files so that they are kept together?

Johann

> Richard.
> 
>> Johann
>>
>> testsuite/
>>        * lib/target-supports.exp (check_effective_target_int32): New
>>        function.
>>        * gcc.c-torture/execute/vect-shuffle-1.c: Don't use
>>        __SIZEOF_INT__.
>>        * gcc.c-torture/execute/vect-shuffle-5.c: Ditto.
>>        * gcc.c-torture/execute/vect-shuffle-1.x: New file.
>>        * gcc.c-torture/execute/vect-shuffle-5.x: New file.



More information about the Gcc-patches mailing list