Fix pr50607 bconstp-3.c failure
Thu Oct 6 03:17:00 GMT 2011
On Thu, Oct 6, 2011 at 3:27 AM, Hans-Peter Nilsson <firstname.lastname@example.org> wrote:
> On Thu, 6 Oct 2011, Artem Shinkarov wrote:
>> Successfully regtested on x86-unknown-linux-gnu. Committed to the
>> mainline with the revision 179588.
>> 2011-10-06 Artjoms Sinkarovs <email@example.com>
>> * c-tree.h (c_expr_t): New typedef for struct c_expr.
>> (C_EXPR_APPEND): New macro.
>> * c-parser.c (c_parser_get_builtin_args): Preserve
>> original_tree_code of c_expr structure. Fixes bconstp-3.c
>> failure of PR50607.
>> (c_parser_postfix_expression): Adjust to the new function.
> Write that changelog entry as:
> PR middle-end/50607
> * c-tree.h (c_expr_t): New typedef for struct c_expr.
> (C_EXPR_APPEND): New macro.
> * c-parser.c (c_parser_get_builtin_args): Preserve
> original_tree_code of c_expr structure.
> (c_parser_postfix_expression): Adjust to the new function.
> (note top marker and without the "Fixes...")
> and there'll be an automatic entry in bugzilla, like for example
> PR50609. You still have to close the bugzilla entry manually
> (not all noteworthy fixes are reason to close a bug report).
> Mostly as a note for the future but you could fix that now, when
> adding the missing empty line after the date+email line. ;)
> brgds, H-P
Thanks for the advice, I didn't know about the automatic mail. Fixed
with commit 179589. As for closing bugzilla entry, I would prefer to
make sure that the patch really fixes the problem. It would be very
helpful if you could confirm this.
More information about the Gcc-patches