[patch] --enable-dynamic-string default for mingw-w64 v2

Paolo Carlini paolo.carlini@oracle.com
Sat Oct 1 10:10:00 GMT 2011


On 10/01/2011 11:48 AM, JonY wrote:
> On 10/1/2011 17:15, Paolo Carlini wrote:
>> On 10/01/2011 08:03 AM, JonY wrote:
>>> Hi,
>>>
>>> I followed Paolo's suggestion with the os_defines.h trick. I duplicated
>>> os/mingw32/ to os/mingw32-w64/ for this to work, since there aren't any
>>> built-in defines to tell the 2 apart unless you include some headers
>>> like _mingw.h.
>>>
>>> Patch attached, comments?
>> These:
>>
>> +#if !defined (_GLIBCXX_FULLY_DYNAMIC_STRING) ||
>> (_GLIBCXX_FULLY_DYNAMIC_STRING == 0)
>>
>>
>> can be simplified to just:
>>
>> +#if _GLIBCXX_FULLY_DYNAMIC_STRING == 0
>>
>>
>> Ok with those changes and a proper ChangeLog entry, of course.
>>
> OK, removed the !defined part and included the ChangeLog, everything OK?
You should have also regenerated configure and config.h.in, right?

Otherwise, patch looks good to me, but I guess we need to hear from a 
mingw maintainer. Kai?

Paolo.



More information about the Gcc-patches mailing list