[Patch] Move Objective-C runtime flags to modern options system.

Richard Guenther rguenther@suse.de
Thu Nov 10 10:39:00 GMT 2011


On Wed, 9 Nov 2011, Mike Stump wrote:

> On Nov 9, 2011, at 10:12 AM, Iain Sandoe wrote:
> > This puts "flag_next_runtime" into the global options structure
> 
> > I needed to deal with '-fobjc-sjlj-exceptions'   and elected to remove it -
> > - this is because there is only one valid exception model for each permutation of runtime and ABI - thus the User flag is just clutter.
> > 
> > It is now ignored as a User flag - and the relevant selection actions are all local to Objective C.
> > 
> > (yay! got rid of one exceptions-related flag :-)) ....
> 
> Yeah, that sounds like a good idea.
> 
> > +ObjC ObjC++ Ignore Warn(switch %qs has been removed and is set automaticaly where required)
> 
> Spelling, automatically.
> 
> > +    targetting Darwin.  However, the flag overrides have not be called yet.  */
> 
> Spelling, targeting.
> 
> > +  if (flag_objc_exceptions)
> > +    /* ??? Should we warn that this is incompatible, if the user has set it.
> > +       For now, just force it it off.  */
> > +    flag_exceptions = 0;
> 
> Where was this in the previous code?  In ObjC++, exceptions can be on for C++ and should not be turned off.  Does this code ever turn off C++ exceptions?

flag_exceptions also triggers middle-end behavior - without it no
statement can possibly throw.  Thus, resetting it can't be ok.

Richard.



More information about the Gcc-patches mailing list