[v3] Re: put __stl_prime_list in comdat section

Xinliang David Li davidxl@google.com
Sat Nov 5 20:40:00 GMT 2011


thanks. The attached is the revised patch.

David

On Sat, Nov 5, 2011 at 11:52 AM, Paolo Carlini <paolo.carlini@oracle.com> wrote:
> On 11/05/2011 07:32 PM, Xinliang David Li wrote:
>>
>> Hi, the following patch is a follow up to the one posted here
>> http://gcc.gnu.org/ml/gcc-patches/2009-05/msg01293.html.
>>
>> The new patch is a header only change and can greatly reduce rodata
>> section size for some programs.
>>
>> Ok for trunk after testing?
>
> As usual for backward/ stuff, I would say largely Ian's call, but please
> don't use get_prime_list unuglified, prefer __get_prime_list, or something
> with _S_* as prefix, being a static member.
>
> Thanks,
> Paolo.
>
> PS: also, make sure to post library patches to libstdc++ too, and, possibly,
> add [v3] to the Subject, otherwise you can easily fail to get the attention
> of the library people.
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: stl_prime.p
Type: application/octet-stream
Size: 1998 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20111105/677d6873/attachment.obj>


More information about the Gcc-patches mailing list