[PATCH] [Annotalysis] Fix ICE caused by ipa-sra optimization.

Diego Novillo dnovillo@google.com
Thu Nov 3 15:59:00 GMT 2011


On Wed, Nov 2, 2011 at 16:48, Delesley Hutchins <delesley@google.com> wrote:
> This patch fixes an ICE caused when the ipa-sra optimization deletes
> function arguments that are referenced from within a thread safety
> attribute.  It will attempt to detect this situation and recover
> gracefully.  Since a graceful recovery is not always possible, an
> optional warning (-Wwarn-thread-optimization) can be turned on to
> inform the user that certain attributes have been removed by
> optimization.
> Bootstrapped and passed gcc regression testsuite on
> x86_64-unknown-linux-gnu.  Okay for google/gcc-4_6?

The patch is missing.

> Changelog.google-4_6:2011-11-02  DeLesley Hutchins  <delesley@google.com>
>    * tree-threadsafe-analyze.c:     Ignores invalid attributes, issues
> a warning, recovers gracefully.   * common.opt:       Adds new thread
> safety warning.
> testsuite/Changelog.google-4_6:2011-11-02  DeLesley Hutchins
> <delesley@google.com>
>    * g++.dg/thread-ann/thread_annot_lock-82.C:     Expanded regression test

The editor at your ChangeLog too ;)



More information about the Gcc-patches mailing list