New port: Renesas RL78

DJ Delorie dj@redhat.com
Wed Nov 2 15:23:00 GMT 2011


> > Index: configure.ac
> > +    # Dereferencing -1 is a compile-time error
> 
> This (those lines) look a little cryptic (and lack punctuation ;)
> Wild improvement guess: "Too small 'int'?".

No, the compiler specifically tests for unaligned accesses and gives a
compile-time error, at Renesas's requrest.  The chip can't do
unaligned accesses correctly, but it doesn't fault - it just silently
accesses the wrong memory.  So the compiler errors instead.

> Also spotted a:
> > Index: libgcc/config/rl78/trampoline.S
> > \ No newline at end of file
> 
> Wouldn't some tools behave better if the asm files had ELF
> decorations on the functions?

Hmmm... perhaps, but this code is from an internal port that already
has gdb, and the gdb engineer hasn't complained yet, and he's usually
the one that points those out to me ;-)

> Also spotted some
> > +#if 1
> and
> > +      /*print_simple_rtl (file, op);*/
> and

I'll fix those.

> > +#if DEBUG0
> and
> > +#if DEBUG_PEEP
> and
> > +#define DEBUG_ALLOC 0

These are intentional, and left in for future debugging.  There are
other ports like that.



More information about the Gcc-patches mailing list