[PR testsuite/47013] Fix SMS testsuite faliures (re-submission)
Rainer Orth
ro@CeBiTec.Uni-Bielefeld.DE
Thu May 19 16:52:00 GMT 2011
Revital,
you should seek review from a subject matter expert (Ayal, I suppose).
Just a few nits on the testsuite side:
> testsuite/Changelog
>
> PR rtl-optimization/47013
> * gcc.dg/sms-2.c: Change scan-tree-dump-times and the code itself
> to preserve the function.
> * gcc.dg/sms-6.c: Add --param sms-min-sc=1
> -fmodulo-sched-allow-regmoves,
> and -mno-update for PowerPC.
^ superfluous whitespace
I usually list the exact target triplets instead of PowerPC, SPU, but
that may be a matter of taste.
> Index: testsuite/gcc.dg/sms-6.c
> ===================================================================
> --- testsuite/gcc.dg/sms-6.c (revision 173659)
> +++ testsuite/gcc.dg/sms-6.c (working copy)
> @@ -1,5 +1,7 @@
> /* { dg-do run } */
> -/* { dg-options "-O2 -fmodulo-sched -fdump-rtl-sms" } */
> +/* { dg-options "-O2 -fmodulo-sched -fdump-rtl-sms --param sms-min-sc=1 " } */
> +/* { dg-options "-O2 -fmodulo-sched -fdump-rtl-sms -mno-update --param sms-min-sc=1 -fmodulo-sched-allow-regmoves " { target powerpc*-*-*} } */
^ try to avoid
superfluous whitespace
> +
and blank lines.
> Index: testsuite/gcc.dg/sms-7.c
> ===================================================================
> --- testsuite/gcc.dg/sms-7.c (revision 173659)
> +++ testsuite/gcc.dg/sms-7.c (working copy)
> @@ -1,5 +1,6 @@
> /* { dg-do run } */
> -/* { dg-options "-O2 -fmodulo-sched -fstrict-aliasing -fdump-rtl-sms" } */
> +/* { dg-options "-O3 -fmodulo-sched -fstrict-aliasing -fdump-rtl-sms -fmodulo-sched-allow-regmoves --param sms-min-sc=1" } */
> +/* { dg-options "-O2 -fmodulo-sched -fstrict-aliasing -fdump-rtl-sms --param sms-min-sc=1 -mno-update -fmodulo-sched-allow-regmoves" { target powerpc*-*-*} } */
>
> extern void abort (void);
>
> @@ -44,7 +45,7 @@ int main()
> return 0;
> }
>
> -/* { dg-final { scan-rtl-dump-times "SMS succeeded" 1 "sms" { target spu-*-* } } } */
> +/* { dg-final { scan-rtl-dump-times "SMS succeeded" 2 "sms" { target spu-*-* } } } */
> /* { dg-final { scan-rtl-dump-times "SMS succeeded" 3 "sms" { target powerpc*-*-* } } } */
^ again: one
space, two
spaces at random?
Thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
More information about the Gcc-patches
mailing list