rs6000_handle_option global state avoidance, part 1
Michael Meissner
meissner@linux.vnet.ibm.com
Thu May 5 19:18:00 GMT 2011
On Thu, May 05, 2011 at 10:08:24AM -0700, Michael Eager wrote:
> David Edelsohn wrote:
> >On Wed, May 4, 2011 at 7:54 AM, Joseph S. Myers <joseph@codesourcery.com> wrote:
> >
> >>Two options, -mcmodel= and -mfpu=, had cases that fell through to the
> >>next case without comments to indicate if this was intended. I added
> >>comments to make the semantics explicit. Given the documentation, it
> >>may well be intentional for -mcmodel= but is more doubtful for -mfpu=.
> >
> >I doubt that either of the fall through cases was intended.
> >
> >Alan, is mcmodel suppose to set m64?
> >
> >Michael, is mfpu suppose to set mrecip?
>
> No. There was a break statement at the end of case OPT_mfpu which
> disappeared when OPT_mrecip was added.
Yes, it was an error on my part. Sorry. I will fix the GCC 4.6 branch. I
will hold off fixing the on trunk, on the assumption this patch will go in. I
can fix it if desired.
--
Michael Meissner, IBM
5 Technology Place Drive, M/S 2757, Westford, MA 01886-3141, USA
meissner@linux.vnet.ibm.com fax +1 (978) 399-6899
More information about the Gcc-patches
mailing list