[patch, libgfortran] Bug 48030 - Implement read_x using fbuf_getc

[Janne Blomqvist]

On Wed, Mar 23, 2011 at 07:15, Jerry DeLisle <jvdelisle@frontier.com> wrote:
> On 03/22/2011 06:19 AM, Janne Blomqvist wrote:
>>
>> On Tue, Mar 22, 2011 at 03:15, Jerry DeLisle<jvdelisle@frontier.com>
>>  wrote:
>>>
>>> Ping
>>>
>>> On 03/19/2011 09:46 PM, Jerry DeLisle wrote:
>>>>
>>>> Hi,
>>>>
>>>> The attached patch re-implements read_x using fbuf_getc. Self
>>>> explanatory.
>>
>> I suspect this doesn't actually fix the issue with reading from a pipe
>> before we have consumed all existing data in all cases, as in line
>> 1212 fbuf_read() is still called. Thus I think we should fold this EOF
>> detection in line 1212-1228 into the main while loop similar to
>> transfer.c:read_sf(). Or am I missing something?
>>
>>
> No, my bad. I forgot to delete some of the old code and when I was done I
> just looked at the diff and did not see what I had not deleted.
>
> Attached is corrected, once again regression tested.

Ok for trunk. Thanks for the patch.


-- 
Janne Blomqvist