[pph] Fix binding_level's names_size streaming (issue4634071)

Diego Novillo dnovillo@google.com
Wed Jun 22 18:36:00 GMT 2011


On Mon, Jun 20, 2011 at 21:12, Gabriel Charette <gchare@google.com> wrote:

> It appears names_size is not even used anywhere in the code
> (or at least I couldn't find any use of it with `grep "names_size" -R gcc/`.
> Should we just remove it?

Yes, we should remove it.

Jason, the field cp_binding_level.names_size is essentially write-only:

$ grep -r '\<names_size\>' .
./ChangeLog-2002:       names_size and vtables.
./ChangeLog-2002:       (wrapup_globals_for_namespace): Use names_size instead
./cp/ChangeLog-2002:    names_size and vtables.
./cp/ChangeLog-2002:    (wrapup_globals_for_namespace): Use names_size instead
./cp/name-lookup.h:    size_t names_size;
./cp/name-lookup.c:      b->names_size++;

I suppose it's OK to remove it, right?


Diego.



More information about the Gcc-patches mailing list