Remove TARGET_HELP hook

Denis Chertykov
Mon Jun 20 16:58:00 GMT 2011

2011/6/20 Weddington, Eric <>:
>> -----Original Message-----
>> From: Joseph Myers []
>> Sent: Monday, June 20, 2011 9:47 AM
>> To:
>> Cc:;; Weddington, Eric
>> Subject: Remove TARGET_HELP hook
>> When moving hooks used in opts.c to the common hooks structure so they
>> can be called from the driver, I did not move the TARGET_HELP hook
>> because this hook is obsoleted by the generic Enum .opt facility (only
>> being used to print list of enumerated arguments to options).
>> Instead, this patch converts the one remaining target with a
>> TARGET_HELP implementation, AVR, to use Enum for the relevant option
>> (with a .def file in the same style as various other targets), and
>> removes and poisons the hook.
>> Bootstrapped with no regressions on x86_64-unknown-linux-gnu, and
>> tested building cc1 and xgcc for cross to avr-elf.  Will common to
>> trunk in the absence of target maintainer objections.
> I assume that this new method still prints out the avr mcu list in a similar fashion?
> I have no overwhelming objections. Though I'd rather wait a little to see if either Denis or Anatoly have any objections.
> Thanks for doing this work, Joseph.

I can not object to this patch.


More information about the Gcc-patches mailing list