PING: PATCH: PR other/49325: Incorrect target HAVE_INITFINI_ARRAY check

Paolo Bonzini bonzini@gnu.org
Sat Jun 18 14:21:00 GMT 2011


On Sat, Jun 18, 2011 at 01:24, H.J. Lu <hjl.tools@gmail.com> wrote:
>> Why are you not changing the gcc_AC_ macro and instead introducing
>> duplicate code? Perhaps the right solution is to add a final argument
>> to the AC_RUN_IFELSE macro (don't know, I should be on holiday and
>> hence I do not have the source code at hand :)); in any case this is
>> _not_ how you add tests that work for cross compilation.
>
> This target test needs run-time check.  I don't know how to properly
> check it for cross compilation and I don't feel comfortable to change
>  AC_RUN_IFELSE.
>
> Here is the updated patch to fix gcc_AC_INITFINI_ARRAY instead.

Better.  However, the test needs to be $build = $target && $build =
$host.  Should be okay with that change, but please repost.

It is also better to change the cross compilation results (the new
"else" branch and the final argument to AC_RUN_IFELSE) to "guessing
no".

Paolo



More information about the Gcc-patches mailing list