[PATCH, Fortran] (Coarray) Change declaration of CAF sync functions.

Daniel Carrera dcarrera@gmail.com
Fri Jun 10 11:41:00 GMT 2011


On 06/10/2011 12:23 PM, Tobias Burnus wrote:
>> + /* SYNC ALL => stat == null_pointer_node
>> + SYNC ALL(stat=s) => stat has an integer type
>> +
>> + If "stat" has the wrong integer type, use a temp variable of
>> + the right type and later cast the result back into "stat". */
>
> Intending: The last two lines were space instead of tab-space indented.
> Additionally, I think you editor automatically indents lines, which
> causes tailing whitespace in (otherwise) empty lines. I remove those
> (trans-expr.c, mpi.c).


It's partly the editor and partly me. I like empty lines to have the 
same indentation as the code and it didn't occur to me that other people 
might not like it.

I'll try to be mindful to not have trailing whitespace in empty lines.


>> sync_1.f90:
>>
>> ! { dg-do run }
>> ! { dg-shouldfail "error stop" }
>
> As the ERROR STOP has been removed, the test no longer fails. Hence,
> also the "dg-shouldfail" has to be removed.

Ooops.



> It is a frequent problem that one forgets to run the new test cases
> through the testing system, leading to such failures. Or if one did, one
> forgets to do it again after some "trivial" test-case change. ;-)

I thought that I *couldn't* run this test through the test system 
because mpi.c is not currently compiled. I thought the only way to run 
the test for now was to do it manually like I did this week.

Well, now I know. Thanks.


> With those changes, the patch is OK. I have now committed the patch as
> Rev. 174896.
>
> Congratulation to your first GCC patch!

WHOO HOO!!!  \o/

-- 
I'm not overweight, I'm undertall.



More information about the Gcc-patches mailing list