[testsuite] skip ARM tests with conflicting options

Mike Stump mikestump@comcast.net
Wed Jun 8 19:34:00 GMT 2011


On Jun 8, 2011, at 8:28 AM, Janis Johnson wrote:
> The big question is whether such a test should be run for all multilibs
> that might possibly pass the test, or only for default and for mulitlibs
> that provide the same options.

Here, reasonable people may disagree.  I suspect in the end, we'll have both solutions, and then individual testcases will make their own decision.  A collection of testcases will tend to follow the same convention...  So, for objective-c, we face the same sort of issue, and we do what we do, and that isn't necessarily going to match exactly what for example the gcc.arm does, nor I suspect are we going to change just because gcc.arm changes.  I think it makes sense to cache as much as possible and skip conflicts.  Taking off my testsuite maintainer hat, I think soft conflicts with defaults should mean we run it, and punch in the options we want.  If there is something that prohibits that from working (hard conflict), it should be skipped.  Feel free to ignore this, as I don't know that this is the best answer.

I'd like to think that dg-skip-if and dg-require-effective-target and general target selection is beefy enough to do everything we need it to, or can be made to.



More information about the Gcc-patches mailing list