[pph] Stream TREE_TYPE for identifier node (issue4550121)

Diego Novillo dnovillo@google.com
Tue Jun 7 22:08:00 GMT 2011


On Tue, Jun 7, 2011 at 14:12, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
> On Tue, Jun 7, 2011 at 8:44 PM, Gabriel Charette <gchare@google.com> wrote:
>> We need to stream TREE_TYPE for identifier node.
>
> That seems unlikely, as identifiers do not have a type. There is some
> TREE_TYPE abuse in cp-tree.h, perhaps you should find out what you're
> streaming.

It's used by the C++ parser, so it needs to be streamed in pph.

> Why are you not using accessor macros for the other fields of
> lang_identifier, e.g. not id->label_value but
> IDENTIFIER_LABEL_VALUE(id)?

Yes, this needs to be fixed.


Diego.



More information about the Gcc-patches mailing list