patch trunk: seek plugin also in a language specific directory when given a short name

Basile Starynkevitch basile@starynkevitch.net
Tue Jun 7 05:51:00 GMT 2011


On Mon, 6 Jun 2011 09:14:20 +0100
Jonathan Wakely <jwakely.gcc@gmail.com> wrote some comment about my 
http://gcc.gnu.org/ml/gcc-patches/2011-06/msg00357.html patch:



> I found this hard to read, particularly "using if needed a front-end
> specific subdirectory."
> 
> Maybe "is loaded from the plugin directory, or one of the front-end
> specific subdirectories, so ..."
> 
> +This permits some plugins to be available only to some front-ends.
> 
> How about "This means some plugins are only available to some
> front-ends" instead?

> "Seeked" is not English, the correct word would be "sought" but
> "searched for" would also be OK.

Thanks for your corrections. Here is an improved patch to trunk 174734.
I corrected the spelling errors you nicely spotted and improved a little
documentation phrasing. I also slightly improved the code itself, by
informing the user with more details when a short-named plugin can't be
loaded.

############## gcc/ChangeLog entries ##################
2011-06-07  Basile Starynkevitch  <basile@starynkevitch.net>

	* doc/plugins.texi (Loading plugins): Plugins are also 
	sought in a front-end specific subdirectory.
	(Plugin callbacks): lto1 plugins can't register pragma handlers.

	* plugin.c: Update copyright year.
	(PLUGIN_FILE_SUFFIX): New constant macro.
	(add_new_plugin): Also search short plugins also in a front-end 
	specific sub-directory.
############## gcc/ChangeLog entries ##################

Ok for trunk?
-- 
Basile STARYNKEVITCH         http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mine, sont seulement les miennes} ***
-------------- next part --------------
A non-text attachment was scrubbed...
Name: langplugin-r174734.diff
Type: text/x-diff
Size: 4773 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20110607/9bd67b5e/attachment.bin>


More information about the Gcc-patches mailing list