[google]Backport r174549 Fix 3 test cases incorrectly run in Thumb/Xscale (issue4524090)

Carrot Wei carrot@google.com
Thu Jun 2 20:52:00 GMT 2011


OK for google/main.

thanks
Carrot

On Thu, Jun 2, 2011 at 12:51 PM, Jing Yu <jingyu@google.com> wrote:
> http://gcc.gnu.org/ml/gcc-patches/2010-10/msg00134.html
> Backport r174549 to fix three testcases that are specific to ARM mode
> and therefore should be skipped when compiling for thumb.
>
> Thanks,
> Jing
>
> 2011-06-01  Jing Yu  <jingyu@google.com>
>        Backport r174549
>
>        2011-06-01  Sofiane Naci  <sofiane.naci@arm.com>
>
>        * gcc.target/arm/mmx-1.c: Skip test in -mthumb.
>        * gcc.target/arm/g2.c: Skip test in -mthumb.
>        Skip test unless cpu is xscale.
>        * gcc.target/arm/scd42-2.c: Likewise.
>
> Index: gcc.target/arm/mmx-1.c
> ===================================================================
> --- gcc.target/arm/mmx-1.c      (revision 174299)
> +++ gcc.target/arm/mmx-1.c      (working copy)
> @@ -4,6 +4,7 @@
>  /* { dg-skip-if "Test is specific to the iWMMXt" { arm*-*-* } { "-mcpu=*" } { "-mcpu=iwmmxt" } } */
>  /* { dg-skip-if "Test is specific to the iWMMXt" { arm*-*-* } { "-mabi=*" } { "-mabi=iwmmxt" } } */
>  /* { dg-skip-if "Test is specific to the iWMMXt" { arm*-*-* } { "-march=*" } { "-march=iwmmxt" } } */
> +/* { dg-skip-if "Test is specific to ARM mode" { arm*-*-* } { "-mthumb" } { "" } } */
>  /* { dg-options "-O -mno-apcs-frame -mcpu=iwmmxt -mabi=iwmmxt" } */
>  /* { dg-require-effective-target arm32 } */
>  /* { dg-require-effective-target arm_iwmmxt_ok } */
> Index: gcc.target/arm/g2.c
> ===================================================================
> --- gcc.target/arm/g2.c (revision 174299)
> +++ gcc.target/arm/g2.c (working copy)
> @@ -2,6 +2,8 @@
>  /* { dg-do compile } */
>  /* { dg-options "-mcpu=xscale -O2" } */
>  /* { dg-skip-if "Test is specific to the Xscale" { arm*-*-* } { "-march=*" } { "-march=xscale" } } */
> +/* { dg-skip-if "Test is specific to the Xscale" { arm*-*-* } { "-mcpu=*" } { "-mcpu=xscale" } } */
> +/* { dg-skip-if "Test is specific to ARM mode" { arm*-*-* } { "-mthumb" } { "" } } */
>  /* { dg-require-effective-target arm32 } */
>
>  /* Brett Gaines' test case. */
> Index: gcc.target/arm/scd42-2.c
> ===================================================================
> --- gcc.target/arm/scd42-2.c    (revision 174299)
> +++ gcc.target/arm/scd42-2.c    (working copy)
> @@ -2,6 +2,8 @@
>  /* { dg-do compile } */
>  /* { dg-options "-mcpu=xscale -O" } */
>  /* { dg-skip-if "Test is specific to the Xscale" { arm*-*-* } { "-march=*" } { "-march=xscale" } } */
> +/* { dg-skip-if "Test is specific to the Xscale" { arm*-*-* } { "-mcpu=*" } { "-mcpu=xscale" } } */
> +/* { dg-skip-if "Test is specific to ARM mode" { arm*-*-* } { "-mthumb" } { "" } } */
>  /* { dg-require-effective-target arm32 } */
>
>  unsigned load2(void) __attribute__ ((naked));
>
> --
> This patch is available for review at http://codereview.appspot.com/4524090
>



More information about the Gcc-patches mailing list