[patch] Fix inlining glitch

Eric Botcazou ebotcazou@adacore.com
Mon Jul 25 10:52:00 GMT 2011


> No, the problem here is deciding whether we can inline a clone.
> We look into DECL_STRUCT_FUNCTION that we can't.  The real fix is one
> commented in:
>
>   /* Don't inline if the callee can throw non-call exceptions but the
>      caller cannot.
>      FIXME: this is obviously wrong for LTO where STRUCT_FUNCTION is
> missing. Move the flag into cgraph node or mirror it in the inline summary.
>  */

The irony being that I implemented the flag for the sake of LTO, based on 
suggestions made on this list...  So why is STRUCT_FUNCTION missing now?

> I plan to look into this before next release.  I would, for sure, welcome
> Eric beating me. If he don't have time to do so, I think the patch is OK as
> it is, since it improves the situation despite the fact that it won't fix
> the same problem with WPA.

OK, I'll install the patch for now.

-- 
Eric Botcazou



More information about the Gcc-patches mailing list