Don't use LANGUAGE_C in CLooG (PR bootstrap/49797)

Tobias Grosser grosser@fim.uni-passau.de
Thu Jul 21 17:18:00 GMT 2011


On 07/21/2011 06:09 PM, Sebastian Pop wrote:
> Hi,
>
> On Thu, Jul 21, 2011 at 07:37, Rainer Orth<ro@cebitec.uni-bielefeld.de>  wrote:
>> As described in the PR, the use of LANGUAGE_C in CLooG breaks C++
>> bootstrap on IRIX 6.5.  Both MIPS and Alpha C compilers predefine
>> LANGUAGE_C themselves, which clashes with the CLooG macro in
>> <cloog/pprint.h>.  In a bootstrap with C++, LANGUAGE_C of course isn't
>> defined, so the symbol is missing.
>>
>> As a hack, I had renamed that to CLOOG_LANGUAGE_C in the installed
>> CLooG headers, not noticing the use of LANGUAGE_C in
>> graphite-clast-to-gimple.c.  Since this macro name is obviously far too
>> generic, I propose renaming it to CLOOG_LANGUAGE_C upstream.
>
> I forwarded this question to the cloog-dev mailing list and they like
> this change.
>
>> The current patch accounts for such a change in gcc and allows the
>> mips-sgi-irix6.5 bootstrap to continue.
>>
>> What's the best way forward from here?  Could one of you propose that
>> upstream?  Is the patch below ok for mainline?
>
> Your patch is ok for GCC, please commit.
> You can post a patch for CLooG on cloog-development@googlegroups.com
> Don't forget to update the documentation of CLooG as well.

I am about to post a patch to CLooG. I will take care of pushing it 
upstream.

Tobi



More information about the Gcc-patches mailing list