[Patch, Fortran] PR49791 - Fix legacy namelist support

Tobias Burnus burnus@net-b.de
Wed Jul 20 23:38:00 GMT 2011


This patch partially undoes the change done in PR 46010.

For that patch, first (comment 7)

+              || !dtp->u.p.ionml->touched)

was added - and after not solving the problem, the complete change was 
(comment 9 and committed version)

+		      || !dtp->u.p.ionml->touched
+		      || dtp->u.p.ionml->type == BT_DERIVED)



As the current PR 49791 shows, the "touched" line causes the test case 
to fail. Well, my simple solution was to remove the "touch" line and 
keep only the BT_DERIVED line.

I have not the slightest idea what the "touch" does (while it is clear 
to me why the BT_DERIVED helped with the old PR 46010). Thus, I don't 
know whether there are any side effects. At least there are none which 
the test suite covers.

Build and regtested on x86-64-linux. OK for the trunk?

To which branch versions do we want to backport? The patch for PR 46010 
was applied end of last year and affects the branches 4.4, 4.5 and 4.6. 
As it is a regression, I am inclined to apply it to all versions 
starting from 4.4.

If the patch makes sense, I think it should be have a relatively low 
regression risk: It is close to the before October 2010 version but it 
continues to fix PR 49791. Thus, there should be no problem for 
backporting in this regard.

Tobias
-------------- next part --------------
A non-text attachment was scrubbed...
Name: namelist-legacy.diff
Type: text/x-patch
Size: 1905 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20110720/fea3cb62/attachment.bin>


More information about the Gcc-patches mailing list