[Patch, Fortran] Add caf_runtime_error to libgfortran/caf/single.c

Daniel Carrera dcarrera@gmail.com
Thu Jul 14 16:04:00 GMT 2011


And of course, here is the patch and ChangeLog.

2011-07-14  Daniel Carrera  <dcarrera@gmail.com>

	* caf/single.c:  Include stdarg.h header.
	(caf_runtime_error): New function. Use "exit(EXIT_FAILURE)".
	(_gfortran_caf_register): Use caf_runtime_error.
	(_gfortran_caf_sync_images): Use "exit(EXIT_FAILURE)".
	* caf/mpi.c (caf_runtime_error): Remove "error" parameter.
	Return EXIT_FAILURE instead.
	(_gfortran_caf_register): Update call to caf_runtime_error.
	(_gfortran_caf_sync_all): Ditto.
	(_gfortran_caf_sync_images): Ditto.
	(_gfortran_caf_error_stop_str): Use "exit(EXIT_FAILURE)".


Now I'm just waiting for SVN update before I commit...


On 07/14/2011 05:34 PM, Daniel Carrera wrote:
> Hi Tobias,
>
> As per your suggestion, I'm copying to gfotran and gcc-patches. I've
> made the change your asked and I'm going to commit the patch.
>
> Cheers,
> Daniel.
>
>
> On 07/14/2011 05:31 PM, Tobias Burnus wrote:
>> On 07/14/2011 05:05 PM, Daniel Carrera wrote:
>>> +caf_runtime_error (const char *message, ...)
>>> +{
>>> + va_list ap;
>>> + fprintf (stderr, "Fortran runtime error.");
>>
>> Could you replace "." by ": " (colon, space), I think "Fortran runtime
>> error: Could not ..." looks better than "Fortran runtime error.Could not
>> ...".
>>
>> Otherwise, the patch is OK. Could you then send the patch as to fortran@
>> and gcc-patches@?
>>
>> Tobias
>>
>> PS: You could directly commit the modified patch, simply reply to this
>> email, add a CC to fortran@/gcc-patches@ and attach the patch and
>> changelog. There is no need that I approve the patch again.
>
>


-- 
I'm not overweight, I'm undertall.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: caf-runtime-error.diff
Type: text/x-patch
Size: 3570 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20110714/8d120709/attachment.bin>


More information about the Gcc-patches mailing list