[PATCH, ARM, iWMMXt][1/5]: ARM code generic change
Xinyu Qi
xyqi@marvell.com
Thu Jul 14 07:38:00 GMT 2011
> > Hi,
> >
> > It is the first part of iWMMXt maintenance.
> >
> > *config/arm/arm.c (arm_option_override):
> > Enable iWMMXt with VFP. iWMMXt and NEON are incompatible.
> iWMMXt unsupported under Thumb-2 mode.
> > (arm_expand_binop_builtin): Accept immediate op (with mode VOID)
> > *config/arm/arm.md:
> > Resettle include location of iwmmxt.md so that *arm_movdi
> and *arm_movsi_insn could be used when iWMMXt is enabled.
>
> With the current work in trunk to handle enabled attributes
> and per-alternative predicable attributes (Thanks Bernd) we
> should be able to get rid of *cond_iwmmxt_movsi_insn" in
> iwmmxt.md file. It's not a matter for this patch but for a
> follow-up patch.
>
> Actually we should probably do the same for the various insns
> that are dotted around all over the place with final
> conditions that prevent matching - atleast makes the backend
> description slightly smaller :).
>
> > Add pipeline description file include.
>
> It is enough to say
>
> (<filename>): Include.
>
> in the changelog entry.
>
> The include for the pipeline description file should be with
> the patch that you add this in i.e. patch #5. Please add this
> to MD_INCLUDES in t-arm as well.
>
> Also as a general note, please provide a correct Changelog entry.
>
> This is not the format that we expect Changelog entries to be in.
> Please look at the coding standards on the website for this
> or at other patches submitted with respect to Changelog
> entries. Please fix this for each patch in the patch stack.
>
>
> cheers
> Ramana
Thanks for reviewing. I have updated the patches and the Changelog.
*config/arm/arm.c (arm_option_override): Enable iWMMXt with VFP.
(arm_expand_binop_builtin): Accept VOIDmode op.
*config/arm/arm.md (*arm_movdi, *arm_movsi_insn): Remove condition !TARGET_IWMMXT.
(iwmmxt.md): Include location.
Thanks,
Xinyu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1_generic.diff
Type: application/octet-stream
Size: 3024 bytes
Desc: 1_generic.diff
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20110714/50a47d6c/attachment.obj>
More information about the Gcc-patches
mailing list