[PATCH: ARM] PR 45335 Use ldrd and strd to access two consecutive words

[Jie Zhang]

On 01/28/2011 05:29 PM, Carrot Wei wrote:
> On Fri, Jan 28, 2011 at 11:55 AM, Jie Zhang<jie@codesourcery.com>  wrote:
>> Hi Carrot,
>>
>> On 01/27/2011 05:27 PM, Carrot Wei wrote:
>>>
>>> Oops, gmail wrapped some lines automatically.
>>> Resend them as attachment.
>>>
>> Thanks! I found another (non-technical) issue in your patch.
>>
>> $ grep "^Index" ldrd.txt
>> Index: arm.c
>> Index: arm-protos.h
>> Index: ldmstm.md
>> Index: pr40457-3.c
>> Index: pr45335-2.c
>> Index: pr45335-3.c
>> Index: pr40457-1.c
>> Index: pr40457-2.c
>> Index: pr45335.c
>>
>> the first three files are in gcc/config/arm/ while the other files I believe
>> belong to gcc/testsuite/gcc.target/arm/. I don't know why your patch does
>> not contains those directory information. If you do "svn diff" under gcc/,
>> the patch should contain such directory information.
>>
 > I did "svn diff" in gcc/testsuite/gcc.target/arm/ and gcc/config/arm/
 > separately and concatenate the results together. So you need to break
 > them and apply the patches separately.
 >
This makes it difficult for people to apply and try out our patch. You 
can just make the patch by running "svn diff" from gcc/ once.

Btw, please don't top reply.


Regards,
-- 
Jie Zhang