[commit, spu] Remove ASM_SPEC (Re: [21/25] Specs cleanup: SPU)

Ulrich Weigand uweigand@de.ibm.com
Thu Jan 27 09:23:00 GMT 2011


Joseph Myers wrote:
> On Mon, 17 Jan 2011, Ulrich Weigand wrote:
> 
> > Joseph Myers wrote:
> > 
> > > 	* config/spu/spu-elf.h (ASM_SPEC): Remove %{w:-W}.
> > 
> > I guess that's OK -- but I'm wondering why we then need to
> > keep any definition of ASM_SPEC here in the first place?
> 
> In general when cleaning up specs I've left empty definitions rather than 
> removing them, even if empty is the default, as something that is clearly 
> safe as a local change - whereas removing the definition requires a 
> further non-local check, that no config using this header was relying on 
> overriding a definition of the same macro in a previous header listed in 
> tm_file.  If nothing is relying on the #undef-and-redefine-to-default - if 
> it in fact has no effect on any target using the header - then it can be 
> removed.

OK, I see.  In our case, there is no other definition of ASM_SPEC, so
this can go away.  I've checked in the patch below.

Tested on spu-elf.

Bye,
Ulrich


ChangeLog:

	* config/spu/spu-elf.h (ASM_SPEC): Remove.

Index: gcc/config/spu/spu-elf.h
===================================================================
*** gcc/config/spu/spu-elf.h	(revision 169143)
--- gcc/config/spu/spu-elf.h	(working copy)
***************
*** 78,83 ****
        mcache-size=8  :-lgcc_cache8k; \
                       :-lgcc_cache64k}"
  
- #undef ASM_SPEC
- #define ASM_SPEC  ""
- 
--- 78,80 ----


-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com



More information about the Gcc-patches mailing list