[trans-mem] PR46941: Mark new/delete operators as transaction_pure

Patrick Marlier patrick.marlier@unine.ch
Tue Jan 18 14:59:00 GMT 2011


I am not agree. Functions should be marked as transaction_safe not 
transaction_pure because libitm is managing those new/delete safe 
allocations.

Attached one patch to fix this.

It causes a regression on
* testsuite/g++.dg/tm/pr45940-3.C
* testsuite/g++.dg/tm/pr45940-4.C

but it seems another problem, reported here:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47340

Removing the transaction_safe declaration on these testcases make them pass.

Changelog

	* cp/decl.c (push_cp_library_fn): Mark function as
	transaction_safe.

On 01/12/2011 07:59 PM, Richard Henderson wrote:
> On 01/12/2011 10:38 AM, Aldy Hernandez wrote:
>> 	* cp/decl.c (push_cp_library_fn): Mark function as
>> 	transaction_pure.
>
> Ok.
>
>
> r~
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: newdelete-safe.patch
Type: text/x-patch
Size: 831 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20110118/84fdfb8b/attachment.bin>


More information about the Gcc-patches mailing list