[PATCH 00/28] mn10300 cleanup + compare-elim, v2

Nick Clifton nickc@redhat.com
Tue Jan 11 14:20:00 GMT 2011


Hi Richard,

> Aka, how I spent my xmas vacation.  ;-)

Thanks dude. :-)

> It may now be too late for the inclusion of the compare-elim
> pass in 4.6, but I thought I'd post it anyway.  Some of the
> target cleanup work might still go in, and I certainly don't
> want Nick to duplicate work if he gets back to work on the port.

You have perfect timing - I was just about to start in on this again.

> Comments appreciated.


>    mn10300: delete ASM_PN_FORMAT
> Is there any real reason for this?

No.  I think that it is a hang over from basing the v850 port on a much 
older port.

Aside: I could not find ASM_PN_FORMAT documented anywhere in gcc/doc/*. 
  I did find the description of the ASM_FORMAT_PRIVATE_NAME macro, but 
no hint that ASM_PN_FORMAT could be used instead.


>    mn10300: fp insn cleanup

Just a very minor point:

> -   (clobber (reg:CC_FLOAT CC_REG))
> -  ]
> +   (clobber (reg:CC_FLOAT CC_REG))]

Is this a formatting requirement ?  It makes more sense to me to treat 
closing parentheses in the same way as they are treated in C code - ie 
with them on a line on their own directly underneath their corresponding 
opening parenthesis.  If it is a requirement though, then please accept 
my apologies for formatting the code incorrectly.


Anyway thank you very much for doing this work and I hope that you will 
be checking the patches in soon.

Cheers
   Nick



More information about the Gcc-patches mailing list