[PATCH] * doc/install.texi: Document availability of cloog-0.16

Jack Howarth howarth@bromo.med.uc.edu
Sun Jan 9 01:01:00 GMT 2011


On Sat, Jan 08, 2011 at 06:09:43PM -0500, Tobias Grosser wrote:
> On 01/08/2011 05:52 PM, Jack Howarth wrote:
>> On Sat, Jan 08, 2011 at 03:35:49PM -0500, Jack Howarth wrote:
>>> On Sat, Jan 08, 2011 at 10:44:54AM -0500, Tobias Grosser wrote:
>>>> On 01/08/2011 07:10 AM, Gerald Pfeifer wrote:
>>>>> On Thu, 6 Jan 2011, Tobias Grosser wrote:
>>>>>> thanks for the comments. I just added information to that install.texi
>>>>>> file, which made it really hard to read. I now tried to restructure
>>>>>> the whole comment and hope it became easier to read.
>>>>>
>>>>> Definitely, thanks a lot. Now I managed to parse this just fine. ;-)
>>>>>
>>>>> Mind the long lines and break them, otherwise this looks good.
>>>>
>>>> OK. Thanks.
>>>>
>>>> I will commit this as soon as the related CLooG packages are uploaded.
>>>>
>>>> Cheers
>>>> Tobi
>>>
>>> Tobi,
>>>     I am confused by the configure code that sets CFLAGS to -O1 when
>>> gcc 4.2.x is in use. Reverting this change on x86_64-apple-darwin10
>>> still allows cloog 0.16.1 to build on x86_64-apple-darwin10 without
>>> any regressions in the cloog testsuite. This is built against the
>>> gcc 4.2.1 compiler in Xcode 3.2.5. I also find that building against
>>> gcc-4.2 and g++-4.2 from Xcode 3.1.4 under powerpc-apple-darwin9
>>> produces no cloog testsuite failures. Perhaps the cloog/isl/configure
>>> test could be enhanced to not set -O1 if the gcc 4.2.x is "Apple Inc. build"
>>> since Apple uses a very forked branch of gcc 4.2.1...
>>>
>>> gcc -v
>>> Using built-in specs.
>>> Target: i686-apple-darwin10
>>> Configured with: /var/tmp/gcc/gcc-5664~89/src/configure --disable-checking --enable-werror --prefix=/usr --mandir=/share/man --enable-languages=c,objc,c++,obj-c++ --program-transform-name=/^[cg][^.-]*$/s/$/-4.2/ --with-slibdir=/usr/lib --build=i686-apple-darwin10 --program-prefix=i686-apple-darwin10- --host=x86_64-apple-darwin10 --target=i686-apple-darwin10 --with-gxx-include-dir=/include/c++/4.2.1
>>> Thread model: posix
>>> gcc version 4.2.1 (Apple Inc. build 5664)
>>>
>>> I'll test current gcc trunk built with -enable-cloog-backend=isl against
>>> a -O3 isl build to check for regressions in graphite.
>>>             Jack
>>
>> Tobi,
>>    A build of current gcc trunk with -enable-cloog-backend=isl against cloog 0.16.1 built
>> entirely at -O3 shows no regressions in the graphite.exp tests on x86_64-apple-darwin10.
>> So it seems unnecessary to resort to -O1 in the isl build within cloog when Apple's
>> gcc 4.2.1 is in use.
>>               Jack
>
> Hi Jack,
>
> thanks for testing. Even if I am not sure that the graphite test suite  
> is large enough to find all subtile bugs, but in case of Apple's gcc  
> 4.2.1 it is probably save to assume it is not a gcc 4.2.1 any more. Do  
> you think you could provide a patch for Cloog that implements your  
> suggestions, such that Sven can include it in the next Cloog release.
>
> Thanks a lot
> Tobi

Tobi,
   The simplest fix would be...

--- isl/m4/ax_cc_maxopt.m4.org	2011-01-08 18:12:56.000000000 -0500
+++ isl/m4/ax_cc_maxopt.m4	2011-01-08 19:20:53.000000000 -0500
@@ -151,7 +151,7 @@
      AX_GCC_ARCHFLAG($acx_maxopt_portable)
 
      # drop to -O1 for gcc 4.2
-     $CC --version |
+     $CC --version | grep -v 'Apple Inc' |
 	sed -e 's/.* \(@<:@0-9@:>@@<:@0-9@:>@*\)\.\(@<:@0-9@:>@@<:@0-9@:>@*\).*/\1 \2/' |
 	(read major minor
 	    if test $major -eq 4 -a $minor -eq 2; then

so that the test is short-circuited on Apple's compiler builds. Applying this change
directly to isl/configure, I've confirmed that this properly applies -O1 for a GNU gcc
4.2 compiler and not for Apple's compilers.
             Jack



More information about the Gcc-patches mailing list