[PATCH][libstdc++-v3 parallel mode] Ambiguities (incl. std::mismatch)

Johannes Singler singler@kit.edu
Fri Feb 25 14:37:00 GMT 2011


On 01/25/2011 08:22 PM, Paolo Carlini wrote:
> Hi,
>> I have come to the conclusion that my patch from 2010-03-22 was mostly
>> bogus (r157643), and deactivated parallel execution for the affected
>> routines in certain cases.  The namespace _GLIBCXX_STD_P always
>> suggests "parallel", but it is the very opposite :-(
>>
>> I have added test cases (for conformance) to existing files since this
>> is the problem of mixing implicit and explicit calls to the parallel
>> mode again.
>>
>> Tested x86_64-unknown-linux-gnu: No regressions
>>
>> Please approve for mainline and gcc-4_5-branch, also waiting for the
>> feedback of François.
> Thanks for sorting out this issue. Patch is Ok for mainline now and in a
> week or so for 4_5-branch too, assuming of course you tested both make
> check and make check-parallel.

Tested x86_64-unknown-linux-gnu: No regressions

Committed.

2011-02-25  Johannes Singler  <singler@kit.edu>

         * include/parallel/numeric (inner_product, partial_sum):
         Qualify subsequent call with __gnu_parallel instead of
         _GLIBCXX_STD_P to reenable parallel execution without ambiguity.
         * include/parallel/algobase.h (equal): Likewise.
         * include/parallel/algo.h (find_first_of, search_n, merge,
         nth_element, partial_sort, max_element, min_element): Likewise.
         * testsuite/25_algorithms/headers/algorithm/
         parallel_algorithm_mixed1.cc (main): Add respective test cases.
         * testsuite/25_algorithms/headers/algorithm/
         parallel_algorithm_mixed2.cc (main): Likewise.
         * testsuite/26_numerics/headers/numeric/
         parallel_numeric_mixed1.cc (main): Likewise.
         * testsuite/26_numerics/headers/numeric/
         parallel_numeric_mixed2.cc (main): Likewise.

Johannes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ambiguities_corrected_4_5.patch
Type: text/x-patch
Size: 14215 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20110225/e60b2616/attachment.bin>


More information about the Gcc-patches mailing list