Patch ping

[Jakub Jelinek]

On Thu, Feb 03, 2011 at 08:14:23AM -0800, Richard Henderson wrote:
> On 02/03/2011 03:58 AM, Jakub Jelinek wrote:
> > The following patch is awaiting review for a week:
> > 
> > - http://gcc.gnu.org/ml/gcc-patches/2011-01/msg02059.html
> >   P1 PR31490, section flags conflict handling
> 
> I think the second patch, attempting to keep the warnings in declaration order,
> is better.  I don't think there's so much extra work to warrant the inconsistency.

Thanks.

> One change though,
> 
> >  /* Private flag applied to disable section-anchors in a particular section.
> >     This needs to be kept in sync with the flags used by varasm.c (defined in
> >     output.h).  */
> > -#define SECTION_NO_ANCHOR 0x2000000
> > +#define SECTION_NO_ANCHOR 0x4000000
> 
> That ought to have been defined as (SECTION_MACH_DEP << 1).  That does leave
> the comment slightly out of date -- "other machine-dependent uses" perhaps?

Well, it perhaps could be just SECTION_MACH_DEP, at least I can't see any
reasons why it couldn't, just the assert required that it was bigger:

config/darwin.c:  gcc_assert (SECTION_NO_ANCHOR > SECTION_MACH_DEP);
config/alpha/alpha.c:#define SECTION_PUBLIC SECTION_MACH_DEP
config/i386/winnt.c:#define SECTION_PE_SHARED	SECTION_MACH_DEP
config/ia64/ia64.c:#define SECTION_VMS_OVERLAY SECTION_MACH_DEP
config/mep/mep.c:#define SECTION_MEP_VLIW	SECTION_MACH_DEP

darwin doesn't support alpha/ia64/mep (I hope) and is not winnt.
I just can't test it on Darwin.

	Jakub