[testsuite, ada] Convert ACATS to DejaGnu (PR testsuite/37703)
Joseph S. Myers
joseph@codesourcery.com
Tue Feb 1 17:24:00 GMT 2011
On Tue, 1 Feb 2011, Rainer Orth wrote:
> Michael Matz <matz@suse.de> writes:
>
> > If Solaris as works with the version in elfos.h (using .string and
> > .ascii) you can just remove it from i386/sysv4.h.
>
> I'll give that a try, all the way back to Solaris 8. Since
> i386/sysv4.h is only used on Solaris 2/x86, I don't even need approval
> for such a change.
Whether using the elfos.h version works or not, it's clearly silly for
this code to be using a quadratic algorithm as the i386/sysv4.h is doing
at present (recomputing the location of the next 0 byte for every byte in
the string - elfos.h saves last_null to avoid that).
For the general issue: a slow test appears to have served its purpose by
showing up a (target-specific) bug in the compiler. And in general you
need to consider whether a resource-hungry test is actually showing up a
bug and should not be so resource-hungry, before reducing the test size or
only running it conditionally. (You might still reduce it after finding
it shows a bug - but only after filing that bug in Bugzilla; not simply
blindly presume that the test is too big for the testsuite.)
--
Joseph S. Myers
joseph@codesourcery.com
More information about the Gcc-patches
mailing list