[PR48743] cpuid family6 fix for Athlon: okay for trunk?

[Quentin Neill]

On Mon, Dec 12, 2011 at 3:00 PM, Uros Bizjak <ubizjak@gmail.com> wrote:
> Hello!
>
>> I'm testing the patch in
>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48743#c4 against trunk
>
>
> --cut here--
> --- gcc-4.7-20110521/gcc/config/i386/driver-i386.c.~1~  2011-01-06
> 23:59:46.000000000 +0100
> +++ gcc-4.7-20110521/gcc/config/i386/driver-i386.c.~1~  2011-05-22
> 16:05:41.000000000 +0200
> @@ -506,7 +506,7 @@ const char *host_detect_local_cpu (int a
>        processor = PROCESSOR_AMDFAM10;
>       else if (has_sse2 || has_longmode)
>        processor = PROCESSOR_K8;
> -      else if (has_3dnowp)
> +      else if (has_3dnowp && family == 6)
>        processor = PROCESSOR_ATHLON;
>       else if (has_mmx)
>        processor = PROCESSOR_K6;
> --cut here--
>
> The patch looks correct to me.
>
>> Is this considered okay for stage3?
>
> Yes, since it fixes a bug.
>
>> If so, okay to commit after bootstrap testing on x86_64?
>
> OK, with a correct ChangeLog.
>
> Uros.

Fixed in r182489, updated http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48743#c7

I got the correct gcc/ChangeLog ... but looks like I committed with
two date/author lines in the svn log.  Grrrr.

I guess if someone has svnadmin permissions on gcc.gnu.org it could be fixed.
-- 
Quentin