[PATCH, ARM, iWMMXt][1/5]: ARM code generic change

Ramana Radhakrishnan ramana.radhakrishnan@linaro.org
Thu Aug 18 02:21:00 GMT 2011


Hi ,

Sorry about the delayed review - It's taken me a while to get back to this .

On 14 July 2011 08:35, Xinyu Qi <xyqi@marvell.com> wrote:
>> > Hi,
>> >
>> > It is the first part of iWMMXt maintenance.
>> >
>> > *config/arm/arm.c (arm_option_override):
>> >   Enable iWMMXt with VFP. iWMMXt and NEON are incompatible.
>> iWMMXt unsupported under Thumb-2 mode.
>> >   (arm_expand_binop_builtin): Accept immediate op (with mode VOID)
>> > *config/arm/arm.md:
>> >   Resettle include location of iwmmxt.md so that *arm_movdi
>> and *arm_movsi_insn could be used when iWMMXt is enabled.

This is OK modulo the Changelog entry.

Please write this as :

<TAB>* config/arm/arm.c (arm_option_override): Enable use of iwMMXt
with VFP. Disable use of iwMMXt and Neon.
<TAB>* config/arm/arm.md (iwmmxt.md): Include earlier.
            (*arm_movsi_insn): Remove check for TARGET_IWMMXT.
            (*arm_movdi_insn): Likewise.


cheers
Ramana



More information about the Gcc-patches mailing list