[lto] Refactor streamer (1/N) (issue4809083)

[Diego Novillo]

On Mon, Aug 8, 2011 at 10:35, Jack Howarth <howarth@bromo.med.uc.edu> wrote:
> On Mon, Aug 08, 2011 at 10:23:34AM -0400, Diego Novillo wrote:
>>
>> This is the first patch in a series of refactoring patches to cleanup
>> the API for the LTO streamer.  I need this cleanup so I can change the
>> way things like caching and external references work in PPH.  With the
>> current code, I would need to introduce even more streamer hooks.  But
>> if we simplify the API and create smaller low-level streaming
>> functions, then we can have the LTO and PPH streamer use these
>> functions without having to resort to a lot of callbacks.
>
> Diego,
>   While you are cleaning up the streamer can you also take a look at..
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49992
>
> to see if these duplicate symbols also exist on linux in a non-fatal manner?
> The change in r177358 broke the ability to do a lto-bootstrap on darwin.
> While the lto-bootstrap appears to still work on linux (from the gcc-testresults
> postings), it is unclear if any of these is using the lto-streamer instead
> of the lto linker plugin. I think this should be fixed ASP since darwin is
> probably one of the last targets to still use the lto-streamer instead of
> the linker plugin.

I think we are talking about different things.  The streamer is the
set of low-level functions that pickle and unpickle GCC data
structures.  It has nothing to do with the linker plugin.  All I'm
doing is moving functions around and renaming things.  None of these
patches will change any existing functionality (least of all anything
related to higher-level modules).


Diego.