[pph] Macro Validation Correction (issue4425041)

Lawrence Crowl crowl@google.com
Mon Apr 25 18:58:00 GMT 2011


On 4/22/11, Hans-Peter Nilsson <hp@bitrange.com> wrote:
> On Sat, 16 Apr 2011, Diego Novillo wrote:
>> On Thu, Apr 14, 2011 at 22:01, Lawrence Crowl <crowl@google.com> wrote:
>> > +unsigned char too_many_directives_for_bitfield[
>> > +        N_DIRECTIVES <= (1 << CPP_HASHNODE_INDEX_BITS)
>> > +        ? 1 : -1];
>>
>> Heh, I'm not sure what to think of this trick. I think I like it, though.
>
> One up: better make it a declaration: prepend with "extern".

I will fold that into my next patch.

-- 
Lawrence Crowl



More information about the Gcc-patches mailing list