[pph/libcpp] Allow include callback to not read the file (issue4388057)
Diego Novillo
dnovillo@google.com
Wed Apr 13 17:23:00 GMT 2011
On Wed, Apr 13, 2011 at 12:21, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Diego" == Diego Novillo <dnovillo@google.com> writes:
>
> Lawrence> This change is not source compatible with existing code using
> Lawrence> the callbacks (which may not be in the gcc svn). Perhaps a new
> Lawrence> callback is needed?
>
> Diego> Well, it only changes the return value for the callback. Existing
> Diego> users do not really need to be changed.
>
> Diego> I don't think we want a new callback. The callback would do exactly
> Diego> what cb.include does.
>
> My grep shows 2 places that set this: c-family/c-ppoutput.c and
> fortran/cpp.c. It seems like it would be simple to just update those
> two functions to account for the type change.
Oh, right. Here I was thinking of users outside of gcc, but of course
there aren't those. I'll fix the calls in the existing front ends.
Diego.
More information about the Gcc-patches
mailing list