Add debugging functions for cp_parser (issue4389045)
Richard Guenther
richard.guenther@gmail.com
Wed Apr 13 12:39:00 GMT 2011
On Wed, Apr 13, 2011 at 2:29 PM, Diego Novillo <dnovillo@google.com> wrote:
> On Wed, Apr 13, 2011 at 05:25, Richard Guenther
> <richard.guenther@gmail.com> wrote:
>> On Wed, Apr 13, 2011 at 2:02 AM, <crowl@google.com> wrote:
>>> One oddity, otherwise LGTM.
>>>
>>>
>>> http://codereview.appspot.com/4389045/diff/1/gcc/cp/parser.c
>>> File gcc/cp/parser.c (right):
>>>
>>> http://codereview.appspot.com/4389045/diff/1/gcc/cp/parser.c#newcode375
>>> gcc/cp/parser.c:375: if (flag)
>>> This code will never print "false", so why have it?
>>
>> Can you quote the piece of the patch you are commenting on?
>
> I'm not sure if that can be controlled. When you respond to a hunk on
> Rietveld, it creates the quote automatically. Maybe there is a way of
> increasing the scope of the quote. I'll ask.
Quoting the patch hunk that is associated with the commend would be enough.
Richard.
> Diego.
>
More information about the Gcc-patches
mailing list