[patch objc]: Fix issue about LLP64 and -Wpadded
Kai Tietz
ktietz70@googlemail.com
Thu Sep 30 13:54:00 GMT 2010
2010/9/30 Nicola Pero <nicola.pero@meta-innovation.com>:
>
>> Does this comment looks ok for you? If so, ok for apply?
>
> Yes, it does look Ok, but I'd change the comment a bit (mostly grammar
> changes). In fact, to avoid the back-and-forth about the comment, I
> rewrote the comment for you in a way that seems Ok to me --
>
> /* We pad the structure manually to prevent warning when -Wpadded
> is used. The compiler automatically pads the structures that it
> generates, so this manually padded structure still matches the one
> generated by the compiler, but if we don't pad manually, -Wpadded
> detects that padding is being added and generates annoying warnings.
> This hack is necessary as on LLP64 targets sizeof (long) isn't equal
> to sizeof (void *). */
>
> So, Ok to apply with this reworked comment (or if you don't like it, feel free
> to propose another one). ;-)
>
> Thanks
Ok, I like your version more and applied your comment here ;)
Committed at revision 164746.
Thanks,
Kai
--
| (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination
More information about the Gcc-patches
mailing list