[patch preprocessor]: PR/45362 Dangling reference
Kai Tietz
ktietz70@googlemail.com
Thu Sep 30 08:34:00 GMT 2010
2010/9/29 Tom Tromey <tromey@redhat.com>:
>>>>>> "Kai" == Kai Tietz <ktietz70@googlemail.com> writes:
>
> Kai> Tested for x86_64-w64-mingw32 and i686-w64-mingw32. Ok for apply to 4.6?
>
> Thanks for persevering.
>
> Kai> + memcpy (c->definition, defn, sizeof (uchar) * defnlen);
>
> You don't need sizeof (uchar) here.
>
> Kai> + if (c->definition)
> Kai> + free (c->definition);
>
> You don't need the if here. free works fine with NULL pointers.
>
> This is ok with those changes. Thanks again.
>
> Tom
>
Ok, thanks. Adjusted and committed at revision 164729.
Regards,
Kai
--
| (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination
More information about the Gcc-patches
mailing list