fix allocno comparison function misbehavior on overflow

Rainer Orth ro@CeBiTec.Uni-Bielefeld.DE
Thu Sep 16 17:44:00 GMT 2010


Vladimir Makarov <vmakarov@redhat.com> writes:

>> The attached patch is a proposal to address this by replacing the difference
>> computation by a comparison, factored out in a macro to allow reuse in other
>> places (not in this patch) and provide a clean spot for a general comment.
>>
>> This fixed the observed SEGV with 4.5 and bootstrapped on i386-solaris. Was
>> also bootstrapped and regression tested for mainline on both sparc-solaris
>> and x86_64-linux.
>>
>> OK ?
>>
> Yes.  Thanks for fixing it.

May I backport the fix to the 4.4 and 4.5 branches?  They are equally
affected, the bug accounts for a large part of the remaining
i386-pc-solaris2.8 testsuite failures on those branches, and this is a
regression from 3.4.

Thanks.
	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University



More information about the Gcc-patches mailing list