[PATCH,testsuite] Fix fallout arising from change to assembler output [was Re: [patch win32]: Allow exports of def-file reserved keywords as symbol]

[Kai Tietz]

2010/9/9 Dave Korn <dave.korn.cygwin@gmail.com>:
> On 11/07/2010 10:21, Kai Tietz wrote:
>> 2010/7/11 Kai Tietz <ktietz70@googlemail.com>:
>
>>> Ok, changed patch to use double-quote instead of single-quote. Applied
>>> at revision 162055.
>>>
>>> Thanks,
>>> Kai
>>>
>>
>> Back merged this patch to 4.5.x branch at revision 162057
>
>  Kai, it turns out you forgot to adjust the testsuite.  The presence of quote
> marks causes the following scan-assembler patterns to fail to match (tested on
> i686-pc-cygwin):
>
>> FAIL: g++.dg/ext/dllexport-MI1.C scan-assembler -export:_ZNK2D12vfEv
>> FAIL: g++.dg/ext/dllexport-MI1.C scan-assembler -export:_ZNK2D22vfEv
>> FAIL: g++.dg/ext/dllexport-MI1.C scan-assembler -export:_ZNK3MI12vfEv
>> FAIL: g++.dg/ext/dllexport-MI1.C scan-assembler -export:_ZThn4_NK3MI12vfEv
>> FAIL: g++.dg/ext/dllexport-MI1.C scan-assembler -export:_ZTv0_n12_NK2D12vfEv
>> FAIL: g++.dg/ext/dllexport-MI1.C scan-assembler -export:_ZTV2D1,data
>> FAIL: g++.dg/ext/dllexport-MI1.C scan-assembler -export:_ZN2D2C2ERKS_
>> FAIL: g++.dg/ext/dllexport1.C scan-assembler  -export:_ZN3Bar10inline_barEi
>> FAIL: g++.dg/ext/dllexport1.C scan-assembler  -export:_Z3fooi
>> FAIL: g++.dg/ext/dllexport3.C scan-assembler -export:_ZN2SaD1Ev
>
>  I looked into why this problem hadn't shown up for you, and realised that a
> lot of the tests aren't running on x86_64-w64-mingw32, because they have
> target specifiers like this:
>
>> // { dg-do compile { target i?86-*-cygwin* i?86-*-mingw*} }
>
>  The only one which was running for you is g++.dg/ext/dllexport3.C, and that
> shows a failure in Nightstrike's latest posted results.  The attached patch
> fixes the testsuite failures, but I figured you'd probably like to take a look
> over all the g++.dg/ext/dll*.C files and see about enabling them for your
> targets by changing the MinGW triplet to just "*-*-mingw*".  (I expect they
> ought to work OOTB on your target, shouldn't they?  Might need tweaking to
> make leading underscores optional perhaps.)
>
> gcc/testsuite/ChangeLog:
>
>        * g++.dg/ext/dllexport1.C: Allow for escaped quotes when matching
>        symbols in export directives using scan-assembler.
>        * g++.dg/ext/dllexport-MI1.C: Likewise.
>        * g++.dg/ext/dllexport3.C: Likewise.
>
>  OK for head?  And 4.5 branch?
>
>    cheers,
>      DaveK
>
>
>
>

Hi Dave,

thanks for giving me a point. I'll take a closer look on them. Most of
those tests seem to work nice on x64 mingw, too. So I should enable
them (and I see such side-effects earlier).

Cheers,
Kai

-- 
|  (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination