gengtype improvements for plugins, completed! patch 2/N [verbosity]

Laurynas Biveinis laurynas.biveinis@gmail.com
Thu Sep 9 05:48:00 GMT 2010


The patch looks good to me, but please see below.

2010/9/8 Basile Starynkevitch <basile@starynkevitch.net>:
> In addition of verbose messages, we added a tiny but useful feature to
> gengtype. When it is generating a file gt-foo.h, it renames the old
> version to gt-foo.h~ so that the user could compare the old version
> with the current one. The cleaning in Makefile.in is updated
> appropriately.  Verbosity & renaming of old files go together (in
> verbose mode, the renaming is told to the user).

IMHO please don't, it's a violation of KISS. If gengtype is taking on
a job of Makefile, that is only going to result in surprises, not very
harmful ones, but still. In fact, I don't even like that gengtype
checks if output file is identical to a newly generated output file
before overwriting it and I think it should be done in Makefile with
move-if-change.

A better way IMHO would be to make gengtype output into an own new
directory "gty" or "gengtype" or whatever. Then it would be up to user
to save the old directory before the new run and as a bonus,
everything could be compared in these directories with a single
command.

-- 
Laurynas



More information about the Gcc-patches mailing list