[PATCH][PING] Pass --with-dwarf2 on darwin8

Mike Stump mikestump@comcast.net
Wed Sep 8 22:54:00 GMT 2010


On Sep 8, 2010, at 6:37 AM, Jack Howarth wrote:
> Currently on darwin8 users have to explicitly invoke --with-dwarf2

Why?

The problem I have with the patch is that in the darwin8 timeframe, dwarf was evolving rapidly and being refined, stabs had the productization and the quality.  We know that stabs works well.  dwarf was mostly in and working, but might have quality of implementation issues.  I don't know that enough testing was put into this change to ensure that there are no regressions, so, for example, did you run the gdb testsuite?  Unfortunately, even that, is kinda light.

Also, if we did want to changed it, it should be done in darwin8.h, not here.

> since it's Xcode defaults to stabs. The attached patch passes --with-dwarf2
> on darwin8 in order to assure it builds the standard dwarf2 support. Okay
> for gcc trunk and gcc 4.5.2?
>              Jack
> 
> 2010-08-12  Jack Howarth <howarth@bromo.med.uc.edu>
> 
> 	* configure.ac: Pass --with-dwarf2 on darwin8.
> 	* configure: Regenerate.
> 
> 
> Index: configure.ac
> ===================================================================
> --- configure.ac	(revision 163079)
> +++ configure.ac	(working copy)
> @@ -2506,6 +2506,16 @@
>   esac
> fi
> 
> +# Default to using --with-dwarf2 on certain targets
> +if test x${with_dwarf2} = x ; then
> +  case "${target}" in
> +  *-*-darwin8*)
> +    with_dwarf2=yes;
> +    extra_host_args="${extra_host_args} --with-dwarf2"
> +   ;;
> +  esac
> +fi
> +
> # hpux11 in 64bit mode has libraries in a weird place.  Arrange to find
> # them automatically.
> case "${host}" in
> 
> Thanks in advance.
>         Jack



More information about the Gcc-patches mailing list