Ping! gengtype plugin improvement last2round - patch 1 [declprog]

[Basile Starynkevitch]

On Thu, Oct 14, 2010 at 09:20:24AM -0400, Diego Novillo wrote:
> On 10/04/10 15:47, Basile Starynkevitch wrote:
> 
> >PS. I am beginning to lose hope getting this patch series into 4.6! I
> >can't understand who is interested in OK-ing them (Laurynas' status
> >don't permit it, he is a plain write after approval maintainer like me,
> >not a reviewer). In case some reviewer want to meet me on sunday
> >october 24th before the GCC Summit, I am arriving at Ottawa on saturday
> >evening.
> 
> Let's meet at the summit.  I will try to review this series of
> patches before stage 1 closes.  I have done a cursory review of this
> series of patches and I believe they are mostly OK to go in.

Diego, we can even meet on Sunday 24th october in Ottawa if you like.

> 
> You've had the misfortune of venturing into no-man's land.  There
> are no reviewers/maintainers for this area of the compiler (I'm
> trying to address this atm).
> 
> 
> >create_field_at (pair_p next, type_p type, const c
> >/* Create a fake field with the given type and name. NEXT is the next
> >field in the chain. */
> >#define create_field(next,type,name) \
> >- create_field_all(next,type,name, 0, this_file, __LINE__)
> >+ create_field_all(next,type,name, 0, this_file, __LINE__)
> 
> Space before '('.
> 
> >#define create_optional_field(next,type,name,cond) \
> >- create_optional_field_(next,type,name,cond,__LINE__)
> >+ create_optional_field_(next,type,name,cond,__LINE__)
> 
> Space before '('.
> 
> 
> OK with those changes.  Please be on the lookout for build failures
> due to this.

Committed as revision 165470 to the trunk, with the requested space changes.

A very big thanks to Diego Novillo for having taken time to review
that, and my congratulations to Jeremie Salvucci (in CC). He worked
hard on this series of patches, much more than we expected (his
internship was supposed to be mostly on MELT, and actually he spent
about the same time on gengtype patches and on GCC MELT).

Cheers.

-- 
Basile STARYNKEVITCH         http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mines, sont seulement les miennes} ***