[patch lto/c++/middle-end/windows]: Fix handling of dllexport for LTO as externally_visible

Kai Tietz ktietz70@googlemail.com
Tue Nov 30 11:33:00 GMT 2010


2010/11/30 Kai Tietz <Kai.Tietz@onevision.com>:
> Dave Korn <dave.korn.cygwin@gmail.com> wrote on 29.11.2010 22:25:13:
>
>> On 29/11/2010 20:59, Andrew Pinski wrote:
>> > On Mon, Nov 29, 2010 at 1:20 PM, Dave Korn <dave.korn.
>> cygwin@gmail.com> wrote:
>> >> gcc/ChangeLog:
>> >>
>> >> 2010-11-29  Dave Korn  <...
>> >>
>> >>        * cgraphunit.c (process_function_and_variable_attributes): Fix
>> >>        cut'n'pasteo.
>> >>
>> >>  OK, I take it?
>> >
>> > I think this is the same as PR 46709.
>> >
>> > -- Pinski
>>
>>   Yep, I'm sure it is.  I'll mention it in the changelog when I commit.
>>
>>     cheers,
>>       DaveK
>>
>
> Yes, this is a pasto and pretty obvious.

Suggested patch should fix this issue

        PR middle-end/46709
        * cgraphunit.c (process_function_and_variable_attributes): Fix typo.

Ok for apply?

Kai
-- 
|  (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination

Index: cgraphunit.c
===================================================================
--- cgraphunit.c        (revision 167290)
+++ cgraphunit.c        (working copy)
@@ -844,7 +844,7 @@
        }
       if (TARGET_DLLIMPORT_DECL_ATTRIBUTES
          && lookup_attribute ("dllexport", DECL_ATTRIBUTES (decl))
-         && TREE_PUBLIC (node->decl))
+         && TREE_PUBLIC (vnode->decl))
        {
          if (vnode->finalized)
            varpool_mark_needed_node (vnode);



More information about the Gcc-patches mailing list