[PATCH] Fix missing headers for plugin [was Miss head file diagnostic.h in plugin.h?]

Ralf Wildenhues Ralf.Wildenhues@gmx.de
Tue Nov 30 07:05:00 GMT 2010


* Mingjie Xing wrote on Tue, Nov 30, 2010 at 02:43:45AM CET:
> 2010/11/30 Ralf Wildenhues:
> > But then why is hard-reg-set.h not listed in FUNCTION_H?  Generally,
> > the *_H make macros in gcc/Makefile.in should correspond to directly
> > included headers only (with some set of exceptions that I haven't really
> > grokked yet, sorry).

> I bet you are right. Putting hard-reg-set.h in FUNCTION_H seems
> reasonable.  Here's the updated patch.
> 
> Bootstrapped on ia64-redhat-linux and i486-linux-gnu.

OK then.

Thanks,
Ralf

> 2010-11-30  Mingjie Xing  <mingjie.xing@gmail.com>
> 
>          * gcc-plugin.h: Include coretypes.h.
>          * Makefile.in (FUNCTION_H): Add hard-reg-set.h.

> --- gcc-plugin.h	(revision 167194)
> +++ gcc-plugin.h	(working copy)
> @@ -26,6 +26,7 @@ along with GCC; see the file COPYING3.  
>  
>  #include "config.h"
>  #include "system.h"
> +#include "coretypes.h"
>  #include "highlev-plugin-common.h"
>  #include "hashtab.h"

> --- Makefile.in	(revision 167194)
> +++ Makefile.in	(working copy)
> @@ -907,7 +907,7 @@ ALIAS_H = alias.h coretypes.h
>  EMIT_RTL_H = emit-rtl.h
>  FLAGS_H = flags.h coretypes.h flag-types.h $(OPTIONS_H)
>  OPTIONS_H = options.h flag-types.h $(OPTIONS_H_EXTRA)
> -FUNCTION_H = function.h $(TREE_H) $(HASHTAB_H) vecprim.h $(TM_H)
> +FUNCTION_H = function.h $(TREE_H) $(HASHTAB_H) vecprim.h $(TM_H) hard-reg-set.h
>  EXPR_H = expr.h insn-config.h $(FUNCTION_H) $(RTL_H) $(FLAGS_H) $(TREE_H) $(MACHMODE_H) $(EMIT_RTL_H)
>  OPTABS_H = optabs.h insn-codes.h
>  REGS_H = regs.h $(MACHMODE_H) hard-reg-set.h



More information about the Gcc-patches mailing list